-
Notifications
You must be signed in to change notification settings - Fork 209
Require from_stop_id and to_stop_id in recommended transfer point transfers (empty or 0) #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nsfers (empty or 0)
|
Please don't do things like this: Consult the slack thread for more detail. |
|
@skinkie good point, I updated the description to be clearer. |
|
As per the new governance guidelines, we are starting a one-week review period today, after which we will start the vote. |
Vote? What about implementation requirements? |
|
@skinkie this is a non-functional change (basically a requirement change) and does not require an implementation by a producer and consumer. |
|
To get more eyes on this change before launching a vote, we will extend the review period for another week. |
|
@jasonad123 thanks for chiming in and supporting this! Just to clarify, the vote is not open yet. Your "+1" will only count within the vote period. We will send a general message on the #gtfs channel once the vote opens soon! Also, if you are able to vote in the capacity of a producer or a consumer (i.e. you work for a vendor/agency that creates GTFS or a consumer and you can cast you vote in their name) that would help narrow down the passing requirements! |
Sorry about that - I should’ve read a little more closely and realized the voting period hadn’t actually opened yet! |
Summary
In
transfers.txt, requirefrom_stop_idandto_stop_idwhentransfer_type = 0or is empty (recommended transfer point).This affected requirement rules, therefore it's a non-functional change. It requires a discussion period, a review period and a vote.
Describe the Problem
In
transfers.txt, whentransfer_type = 0or is empty, it means that it is a recommended transfer point between routes, which should include afrom_stop_idandto_stop_id.However, the spec currently only requires
from_stop_idandto_stop_idwhentransfer_type =1, 2 or 3The issue was raised by a community member in the #gtfs Slack channel (thread): "from_stop_id and to_stop_id are "Required if transfer_type is 1, 2, or 3", but aren't they also required if transfer_type=0 or empty?"
Type of change
GTFS Schedule
GTFS Realtime
Proposed Discussion Period
We want to leave the discussion period open until after the holidays to accommodate holiday schedules and to make sure the community has an eye on this. We intend to start a one-week review period and the vote mid-January.
Therefore, we propose a discussion period of 6 weeks (too accommodate the holidays), the discussion period ends on 9 January 2026 at 23:59:59 UTC.
Proposal Update Tracker
Checklist